Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix source map URLs for the legacy API #113

Merged
merged 1 commit into from
Feb 17, 2022
Merged

Fix source map URLs for the legacy API #113

merged 1 commit into from
Feb 17, 2022

Conversation

nex3
Copy link
Contributor

@nex3 nex3 commented Feb 15, 2022

If an importer was passed, these URLs were broken by our end-of-load
import injection. This fixes the issue by explicitly passing a
sourceMapUrl field which allows the wrapper to reconstruct the
correct URLs.

See webpack-contrib/sass-loader#774 (comment)
See sass/sass-spec#1776

If an importer was passed, these URLs were broken by our end-of-load
import injection. This fixes the issue by explicitly passing a
`sourceMapUrl` field which allows the wrapper to reconstruct the
correct URLs.

See webpack-contrib/sass-loader#774 (comment)
@nex3 nex3 merged commit aeac846 into main Feb 17, 2022
@nex3 nex3 deleted the source-map-urls branch February 17, 2022 21:03
nex3 added a commit to sass/dart-sass that referenced this pull request Feb 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants